Skip to content

8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees #25887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees #25887

wants to merge 2 commits into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 18, 2025 •
edited by openjdk bot
Loading

JDK-8333117 removed support for non-local debuggees, so now only local debuggees are supported. However, there are now a lot of references to the "local" debuggee mode which are not necessary because "local" is implied. These references are in comments and API names and should be removed.

Also, after JDK-8333117, DebugeeProcess no longer needs to be considered abstract. It has no abstract methods.

Tested nsk/jdi, nsk/jdb, and nsk/jdwp locally. Will run tier5 CI to get better coverage.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25887/head:pull/25887
$ git checkout pull/25887

Update a local copy of the PR:
$ git checkout pull/25887
$ git pull https://git.openjdk.org/jdk.git pull/25887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25887

View PR using the GUI difftool:
$ git pr show -t 25887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25887.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025 •
edited
Loading

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees

Reviewed-by: lmesnik, sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8333117 8333117: Remove support of remote and manual debuggee launchers Jun 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025 •
edited
Loading

Webrevs

@plummercj plummercj changed the title 8333117: Remove support of remote and manual debuggee launchers 8359958 Jun 18, 2025
@openjdk openjdk bot changed the title 8359958 8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees Jun 18, 2025
@plummercj
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@plummercj The pull request is being re-evaluated and the inactivity timeout has been reset.

lmesnik
lmesnik suggested changes Jun 23, 2025
View reviewed changes
test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java
@@ -52,7 +47,7 @@
* @see nsk.share.jdi.Debugee
* @see nsk.share.jdwp.Debugee
*/
abstract public class DebugeeProcess {
public class DebugeeProcess {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reason to make it non-abstract.. Even DebugeeProcess doesn't have abstract methods, only jid/jdwp subclasses might be used.Might be left it abstract?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it is only used via subclasses, but that doesn't necessarily mean it couldn't be used directly. Is there a reason you want to disallow that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No any particular reason.

sspitsyn
sspitsyn approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 25, 2025
lmesnik
lmesnik approved these changes Jun 30, 2025
View reviewed changes
test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java
@@ -52,7 +47,7 @@
* @see nsk.share.jdi.Debugee
* @see nsk.share.jdwp.Debugee
*/
abstract public class DebugeeProcess {
public class DebugeeProcess {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No any particular reason.

@plummercj
Copy link
Contributor Author

Thanks for the reviews Leonid, Serguei, and Alex!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

Going to push as commit 39c9de2.
Since your change was applied there have been 194 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2025
@openjdk openjdk bot closed this Jul 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@plummercj Pushed as commit 39c9de2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspitsyn sspitsyn sspitsyn approved these changes

@lmesnik lmesnik lmesnik approved these changes

@alexmenkov alexmenkov alexmenkov approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated serviceability [email protected]
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plummercj @sspitsyn @lmesnik @alexmenkov